Accurate error propagation from RoGetActivationFactory - #559
Merged
Conversation
Scottj1s
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #552 to properly capture and propagate error information from RoGetActivationFactory when fallback fails.
RoGetActivationFactory returns REGDB_E_CLASSNOTREG rather than CLASS_E_CLASSNOTAVAILABLE when activation fails. The target DLL may return CLASS_E_CLASSNOTAVAILABLE from DllGetActivationFactory. That's why a few of the tests needed updating since those tests were relying on the previous behavior where RoGetActivationFactory was sidestepped entirely.